[LinuxCNC/linuxcnc PR#93] halshow.tcl: use no special grouping for signals About GRBL HAL

Issue #93 | 状态: 已关闭 | 作者: ikcalB | 创建时间: 2016-06-28

标签: enhancement

    as no example I am aware of, does use sensible signal names, I would
    like to get rid of the special grouping for signals.
(Which makes it really hard, to read dot-delimited signal names)
    I'm able to propose a standard-naming scheme, which would make configs
    much more readable - just had not time, to adapt some of the sample
    configs.

Signed-off-by: Florian Kerle flo.kerle@gmx.at

#1 – jepler 于 2016-07-15

@ikcalB when I run halshow, what should I look for to see how this patch changes things? do I need to create particular signal names to see a difference?

#2 – ikcalB 于 2016-07-19

@jepler the default behavior, is that only for signals, only some keywords trigger a subtree – should say, when using dot-notation to group signals like: X.motor.feedback or X.motor.set-pos, motor is not seen as a parent leaf, and all X.motor... signals are displayed on the same hierarchy level, instead of being grouped together.

#3 – jepler 于 2016-07-19

Before:
!halshow-before

After:
!halshow-after

#4 – jepler 于 2016-07-19

Thank you for the explanation. Now that I see what is going on, I think this makes sense for master.

#5 – jepler 于 2016-07-19

@SebKuzminsky this is a purely cosmetic change, though it probably has a low risk of introducing problems. Do you want this in any of the stable trees, or shall we put it in master only?

#6 – ikcalB 于 2016-07-19

@jepler exactely. That enables grouping signals, i.e. according to functional groups like motors, toolchanger, pallett changer,… And makes finding signals easy

P.S. sry for not providing pics myself – am on vacation, with no laptop. Lcnc for android – not yet released

#7 – SebKuzminsky 于 2016-07-19

@ikcalB you’re working on master, right? No need for this in 2.6 or 2.7?

#8 – jepler 于 2016-07-19

I merged this, but to master branch only. Thanks!

#9 – ikcalB 于 2016-07-19

@SebKuzminsky my ex-company is on stables only, so 2.7.x was fine. They’re able to deal with that manually though.

So master should be fine!

原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/93

评论 (9)