[LinuxCNC/linuxcnc PR#92] halshow.tcl: use no special grouping for signals

未分类 bolang 4个月前 (10-15) 27次浏览

Issue #92 | 状态: 已关闭 | 作者: ikcalB | 创建时间: 2016-06-28

标签: enhancement


    as no example I am aware of, does use sensible signal names, I would
    like to get rid of the special grouping for signals.
(Which makes it really hard, to read dot-delimited signal names)
    I'm able to propose a standard-naming scheme, which would make configs
    much more readable - just had not time, to adapt some of the sample
    configs.

Signed-off-by: Florian Kerle flo.kerle@gmx.at


评论 (3)

#1 – jepler 于 2016-06-28

After this change, it appears that ‘proc makeNodeSig’ would be unused. The PR should delete the whole proc’s implementation.


#2 – ikcalB 于 2016-06-28

@jepler correct, atm it’d be unused. I’m planning on making (non)groupable strings(items) configurable, and wanted to keep proc for later reference.
good idea, y/n? source comment missing?

i.e.: we use the following suffices:

                  bool        int/float
pins:      in    in/nin       get
           out   on/off       set

signals: ok/nok act


#3 – jepler 于 2016-06-28

Personally, I don’t use halshow, so I am not a good person to judge the merits of changes to it. (and I don’t really understand what your table is trying to show). If you want to discuss possible enhancements, I recommend the mailing list or forum where you have a higher chance of finding people who do.

I prefer to delete unused code even if it may be a reference for future code. Remember, the past revisions of that file will always be available to view in git or on github. For local viewing, “git gui” can present you with a file browser of any past version. e.g., git gui browser v2.7.4.


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/92

喜欢 (0)