[LinuxCNC/linuxcnc PR#633] Cleanup docs

#1 – simaoamorim 于 2019-08-11

The include/ and rtlib/ folders are empty, only containing a .gitignore file. Are these folders still used for anything or can they be removed?

The bin/ folder contains a profiling script for axis which is used by ./TODO file whose most recent blame line dates back to 2009? I’m guessing it is highly outdated?

Best regards,
Simão A.

#2 – andypugh 于 2019-08-11

> On 11 Aug 2019, at 23:29, Simão Amorim wrote:
>
> The include/ and rtlib/ folders are empty, only containing a .gitignore file. Are these folders still used for anything or can they be removed?

My impression has always been that these are populated during a rip build. But I have not looked in to it in detail.

#3 – simaoamorim 于 2019-08-11

It would make sense if true. I’ll test that.

#4 – simaoamorim 于 2019-08-12

@andypugh you’re wright, the bin/, include/ and rtlib/ folders got populated in a rip build.

What about removing them from the repository (add them to the .gitignore) and include the necessary mkdir’s into the autogen script?

#5 – andypugh 于 2019-08-12

I have no strong opinions on the subject, but other than neatness, is it worth the trouble?

#6 – simaoamorim 于 2019-08-13

I know it’s only a matter of neatness, but I’ll give it a try because it’s a small change
and if it works the repo gets a bit cleaner

> On 12 Aug 2019, at 22:00, andypugh wrote:

> I have no strong opinions on the subject, but other than neatness, is it worth the trouble?

#7 – andypugh 于 2020-03-21

Hmm, are you still interested in this? I committed your changes and broke the buildbot…
http://buildbot.linuxcnc.org/buildbot/builders/4016.deb-wheezy-i386/builds/3824
It looks like the deb-build process explicitly references files that you deleted. (that’s a guess)

#8 – simaoamorim 于 2020-03-21

@andypugh indeed, I looked at the build log and the deb-build tried to “install docs/UPDATING`, which I moved...
`bash
install -m 0644 -o root ../docs/UPDATING /tmp/buildd/linuxcnc-2.9.0~pre0.1278.g9162192/src/../debian/tmp/usr/share/doc/linuxcnc/UPDATING
install: cannot stat ../docs/UPDATING’: No such file or directory
“`
I can see if I can fix that in the deb-build configs…
Maybe installing the docs/ folder AS IS instead of hard-coding the files inside would solve the issue and, at the same time, give more flexibility when changing / refactoring documentation??
(What’s the point in hard-coding documentation files in a deb-build, anyway?)

#9 – andypugh 于 2020-03-21

I have a fix in the pipeline, just checking it now.

#10 – andypugh 于 2020-03-21

Well, just removing the hard-coded mentions of the removed file isn’t enough.
And I have no idea what the problem is.
The package build complains of files in debian/tmp that shouldn’t be there, but I have no idea how these changes could cause that.

#11 – andypugh 于 2020-03-22

I have reverted all the changes. Just to stop the buildbot bombarding me with blamelist messages.

#12 – simaoamorim 于 2020-03-22

Yeah, don’t mess with the winning team…
I’ll take a look into it and try to fix it

It only happens with the deb-build right? Because the rip build runs fine, no complaints…

Simão Amorim

> On 22 Mar 2020, at 00:35, andypugh wrote:
>
> 
> I have reverted all the changes. Just to stop the buildbot bombarding me with blamelist messages.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.

#13 – andypugh 于 2020-03-22

Looks like Jepler fixed it.

Thanks Jepler.