[LinuxCNC/linuxcnc PR#605] docs – Correct the Python Interface example function ok_for_mdi

#1 – jethornton 于 2019-06-09

Both PR’s are on Master and it looks like your repo was not up to date. You should git pull –rebase before submitting the PR and git checkout 2.7.

#2 – lorenzncode 于 2019-06-09

I changed the base branch of the PR to 2.8. Is that better? If so I can try making the same change to the other PR that was intended for the 2.7 branch.

#3 – lorenzncode 于 2019-06-09

I filed the separate PR for 2.8 because the 2.7 example will not work in 2.8.

For example consider a JOINTS=4 machine with trivkins coordinates=XYYZ in 2.8.

s.axes in 2.8 will return 3
s.joints (new in 2.8) will return 4. This is what we need to compare with s.homed.count(1) for 2.8.