[LinuxCNC/linuxcnc PR#593] Enhanced Renes changes to the non-random tool changer so the tool id …

#1 – mydani 于 2019-05-17

Tests are still left untouched, might fail. Will adapt them in a new commit.

#2 – rene-dev 于 2019-05-17

It might work, but adding the index everywhere is not the way to go.
the index should go entirely, as it is not required, and will be removed in a future version.

#3 – rene-dev 于 2019-05-17

there are no tests checking for what you are fixing. you need to cherrypick and fix sebs toolinfo test from my branch to actually test the tool info.

#4 – mydani 于 2019-05-17

> It might work, but adding the index everywhere is not the way to go.
> the index should go entirely, as it is not required, and will be removed in a future version.

Can you give me a pointer to the recent implementation? Tool table index = pocket sucks imho

#5 – rene-dev 于 2019-05-17

https://github.com/LinuxCNC/linuxcnc/pull/528/
there are a few issues left, and a lot of unpushed code which fixes them that Im still cleaning up.
the tool number is the only thing that should get passed around, as its unique, the only thing that the interpreter cares about, and you can get everything from the tool number.
This is because Im also preparing the code for the new sqlite based tooltable, which has pockets, but no index. this also allows to add arbitrary fields, like max rpm, tool hours, …

#6 – mydani 于 2019-05-17

Sounds very reasonable. Let me know when you need some support or a reviewer. I will close the pull request and keep the SW running at my machines until your branch is available.