[LinuxCNC/linuxcnc PR#580] time.comp: add support for pausing timer.

未分类 bolang 5个月前 (10-15) 28次浏览

Issue #580 | 状态: 已关闭 | 作者: itaib | 创建时间: 2019-04-25



评论 (4)

#1 – mozmck 于 2019-05-16

itaib, I just found your change here after I modified time.comp in a similar manner in 2.7. My change makes the not component unnecessary because time.N.start is connected to halui.program.is-running. I think the component should be the same in all branches, and I kind of like eliminating the not component, so would it be a problem for you if I changed your version in master to my version?


#2 – itaib 于 2019-05-17

no problem.


#3 – mozmck 于 2019-05-17

I merged my changes with yours and I think it’s better yet – thanks!


#4 – itaib 于 2019-05-17

I believe you need to use your code from 2.7.
right now, pausing/unpausing resets the counter.


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/580

喜欢 (0)