[LinuxCNC/linuxcnc PR#554] Zultron/lcnc pr docker cleanup fixes

未分类 bolang 5个月前 (10-15) 38次浏览

Issue #554 | 状态: 已关闭 | 作者: zultron | 创建时间: 2019-02-01


Here are a few cleanups to the scripts/linuxcnc.in and scripts/realtime.in templates.

The most significant update is ignoring defunct zombie processes when cleaning up on exit. These hang around in Docker containers, and aren’t a problem except where they trigger false positives in scripts like these. More info [here][1].

The others are minor: Use the autoconfigured grep executable, and fix a log message.

[1]: https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/


评论 (3)

#1 – zultron 于 2019-02-01

Tests passed.


#2 – zultron 于 2019-02-01

Hold off on this, one more fix coming up


#3 – zultron 于 2019-02-01

There, runtests now run in Docker as well. Tests pass, ready for review. Thanks!


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/554

喜欢 (0)