[LinuxCNC/linuxcnc PR#522] Create public header for hostmot2 public APIs

未分类 bolang 5个月前 (10-15) 23次浏览

Issue #522 | 状态: 已关闭 | 作者: jepler | 创建时间: 2018-10-30


This is trying to address what I think is the actual problem underlying #515. While I didn’t test this with a package, I did test that with an RIP build “mesa_7i65.comp” can be copied out of the tree and built with halcompile –compile. buildbot shows green for kernel-mode RTAI builds, and I tested locally with uspace builds on debian stretch.

This is closely related to #516 but is rebased for 2.7 and the bits about “pktuart” are removed.


评论 (3)

#1 – jepler 于 2018-10-31

@SebKuzminsky pending the results of buildbot and travis I think this is ready for merge. I had initially dropped the two added tests on the floor when I initially created this PR, so we definitely want to wait and see how they shake out.


#2 – jepler 于 2018-11-02

OK, it turns out that the hm2_bspi API has changed from 2.7 to master, gaining several new parameters:

int hm2bspisetup_chan(char *name, int chan, int cs, int bits, float mhz,
- int delay, int cpol, int cpha, int clear, int echo);
+ int delay, int cpol, int cpha, int noclear, int noecho,
+ int samplelate);

@SebKuzminsky is it still worth exposing the API in 2.7, given that the API turned out NOT to be stable?

So hypothetically if the answer is “no”, I’d re-roll with just these commits, I think:
* cb90b024d test that quote-includes get headers next to a comp with halcompile
* 000206b72 Makefile: Put the public includes directory in <>path for modules

Also it looks like I need to PR mesa_7i65.comp not building on uspace for some reason, which I think at least @andypugh had alluded to and I just kind of ignored. :-1:


#3 – jepler 于 2018-11-04

For reasions previously discussed, this PR isn’t suitable for 2.7 in its current form.


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/522

喜欢 (0)