> 未分类 > [LinuxCNC/linuxcnc PR#5] Seb/master/hm2 watchdog

[LinuxCNC/linuxcnc PR#5] Seb/master/hm2 watchdog

未分类 bolang 4个月前 (10-15) 23次浏览

Issue #5 | 状态: 已关闭 | 作者: SebKuzminsky | 创建时间: 2014-08-27

Here’s the hm2 watchdog change we talked about on IRC. It makes the hm2 hal write() function do the petting, and makes the pet_watchdog function just warn that it’s going away.

Tested on Precise/RTAI with a 5i20.

评论 (4)

#1 – jepler 于 2014-08-27

Probably this also requires a change in pncconf so that it doesn’t generate an addf of the removed pet function.

src/emc/usrintf/pncconf/pncconf.py:                print >>file, "addf hm2%s.%d.petwatchdog  servo-thread"% (self["mesa%dcurrentfirmwaredata"% boardnum][_BOARDNAME], halnum)
src/emc/usrintf/pncconf/pncconf.py:                halrun.write( "addf hm2%s.%d.petwatchdog  slow\n"% (self.data["mesa%dcurrentfirmwaredata"% boardnum][_BOARDNAME], halnum))

aside from that, things look pretty good.

#2 – SebKuzminsky 于 2014-08-27

Good call, i missed that. Pushed some more commits with that and some other stuff i’d missed last night. Do i have to make a new PR?

#3 – SebKuzminsky 于 2014-08-27

No need to re-PR, just pushing to the PR’d branch is apparently enough. That’s nice!

#4 – SebKuzminsky 于 2014-08-27

I’ll move the petting to tram and make another PR.
Thanks for the feedback.

原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/5

喜欢 (0)