[LinuxCNC/linuxcnc PR#479] Fix synched spindle moves exceeding linear axis limits

#1 – andypugh 于 2019-11-27

There seems to be quite a collection of open issues around this.
How do things stand for a merge? And into which branch?

#2 – zultron 于 2019-11-29

I haven’t looked at this for a long time. Maybe @robEllenberg remembers this better? This has been in Tormach’s tree since the PR was first opened, so it’s had a few years of testing, albeit only in that single environment.

#3 – robEllenberg 于 2019-12-06

There are some additional fixes that need to be backported before this can be merged into 2.7 (and those fixes also need to make it into 2.8). I’d like to hold off on the merge until I can straighten them out.

#4 – rene-dev 于 2020-05-06

any update on this? sounds like a good feature for the upcoming 2.8 release.

#5 – robEllenberg 于 2020-05-11

Agreed, I think this is an important feature for 2.8. The branch as it stands needs some additional threading fixes backported. Depending on how that goes I’ll either update the PR or make a new branch based on the current 2.8.

#6 – andypugh 于 2021-01-17

Did this go in? I am suspecting not?

#7 – robEllenberg 于 2021-01-20

As far as I know this didn’t get merged. The last time I touched this I ran
into a bunch of merge conflicts trying to backport my changes from the
PathPilot fork, and simply haven’t revisited this in a while. I still
believe that these changes would be a valuable improvement for 2.8. The
good news is that in the intervening time I’ve created a few test cases
(for runtests) to verify performance of spindle synchronization in sim, so
it will make it easier to verify that it’s working as expected. If I can
lean on a few people with hardware to put the new code through its paces
(e.g. Gene), then we can make some progress here.

On Sun, Jan 17, 2021 at 3:45 PM andypugh wrote:

> Did this go in? I am suspecting not?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/LinuxCNC/linuxcnc/pull/479#issuecomment-761877034>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJHUPFUICHMJBDEJPZYOSDS2ND77ANCNFSM4FNUUXUQ>
> .
>

#8 – andypugh 于 2021-01-22

Looking at the merge conflicts reported here in the web editor it doesn’t look too hard, but I think that a rebase on to 2.9 would be needed. And then all the multi-spindle stuff is likely to cause trouble.
But I think it’s worth a try. (And I have a lathe)

#9 – petterreinholdtsen 于 2022-08-20

https://github.com/petterreinholdtsen/linuxcnc/tree/479-test-spindlesync-exceeds-maxvel-on-master is my port of the test to python 3 and upgrade of the ini file to get linuxcnc to accept it.

#10 – petterreinholdtsen 于 2022-08-20

I notice pull request #581 also claim to solve #167. Perhaps this pull request has been superseeded by #581?

#11 – andypugh 于 2025-09-05

This does look to have been superseded.