[LinuxCNC/linuxcnc PR#457] wj200_vfd: *fixed hal options init +short options +usage

#1 – andypugh 于 2018-07-07

I am slightly confused by “option usage”. I can’t find that even as an undocumented option in halcompile.comp.

#2 – jepler 于 2018-07-07

I don’t think “option usage” does anything @andypugh

#3 – oro06 于 2018-07-07

well, discovering how userinit preprocessing was ‘working’ i though i may get a warning or an error from halcompile –preprocess if in the case of usage it wasn’t implemented. seems i was wrong and it was ignored. my intention was/is to have a deeper look at other options available to see if they may be of any help for improved wj200_vfd interface but then once ci was successful and i was testing with my inverter i didn’t check before pulling request.
considering experts are saying “option usage” is currently useless, better to remove this

#4 – andypugh 于 2018-07-29

Where does this stand now?

#5 – oro06 于 2018-11-02

current master version permit only to access device located at
/dev/ttyS0 and i didn’t make it to change the default device to /dev/ttyUSB0
also nothing is logged at the userinit stage so one don’t know what is effectively being used.
searching on the forum showed that others have the same problem and i didn’t found
any solution except updating this comp.
1st commit goal : refactor userinit to have loadusr -W wj200_vfd ... update properly com parameters
and log whaterver is being used
2nd commit goal : avoid few errors logged when module is starting and reduce pooling pressure

so for now , loadusr -W wj200_vfd --device /dev/ttyUSB0 --baud 9600 --parity N --data 8 --stop 1
make it possible to use this module

#6 – andypugh 于 2018-11-02

Do the changes require any changes to existing configs?

#7 – andypugh 于 2018-11-02

https://travis-ci.org/LinuxCNC/linuxcnc/builds/449954365#L2973

Seems to indicate a build failure.

#8 – oro06 于 2018-11-02

sorry, this last commit was not supposed to come to you now,
intention was to have this on my branch( i commited without issuing any PR)
it’s almost a rewrite, so diffs are of no use for reviewing
i’ll look at this and answer your question asap

#9 – oro06 于 2018-11-05

@andypugh this branch is mixing different things, it has been split in
https://github.com/oro06/linuxcnc/tree/oro06-updwj200
and
https://github.com/oro06/linuxcnc/tree/oro06-wj200next
i’ll come up with PR when it’s in better shape