[LinuxCNC/linuxcnc PR#348] Mitigate linuxcnctop memory leak affecting Debian Stretch (and possibly others) About GRBL HAL

Issue #348 | 状态: 已关闭 | 作者: jepler | 创建时间: 2017-11-08

For background, see #347. Compared to the patch I offered there, this sequence of patches mitigates the memory leak better, and also reduces CPU usage.

The change to display of data like ‘ain’ is actually integral, because the patch changes from using the normal python-to-tcl object conversion routines (which separate the values with whitespace and add no delimiters) to the python-to-string conversion routines (which use commas and add delimiters). So without it, the displayed stuff is different.

(the change to wrap at word boundaries isn’t, and I’ll rebase it out if it irritates someone)

It won’t apply to 2.7 but it would not be hard to rebase (I don’t think); there are some conflicts due to JA.

#1 – SebKuzminsky 于 2017-12-01

This looks fine to me. Do you want me to merge it into master, or do you want to fix it in 2.7 and merge up? Either way is fine by me.

#2 – SebKuzminsky 于 2017-12-07

I created a new branch named 2.7-linuxcnctop-stretch-leak, which is @jepler ‘s branch from this PR rebased to 2.7. linuxcnctop runs, but I did not do any other validation.

@jepler, would you mind looking it over, and if it looks good changing this PR to use that branch instead?

#3 – KurtJacobson 于 2017-12-07

Oh wow, I missed this PR. This fix would be great to have in 2.7, as I almost daily get in trouble because I forget and leave linuxcnctop running while troubleshooting. Thanks @jepler!

#4 – SebKuzminsky 于 2017-12-07

I’ve changed my mind since my comment above, and I too would prefer to have this fix in 2.7 now.

#5 – jepler 于 2017-12-07

@SebKuzminsky the changes in your branch look fine, so if @KurtJacobson says it fixed the problem in 2.7 let’s merge it.

#6 – SebKuzminsky 于 2017-12-07

I merged the 2.7 version of this branch instead. I’ll take care of the merge to master.

#7 – SebKuzminsky 于 2017-12-07

@KurtJacobson please let us know if v2.7.11-55-ga0ba0b0 fixes the problem for you.

#8 – KurtJacobson 于 2017-12-07

I can’t test at the moment, but I will tonight or tomorrow morning and report back.

原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/348

评论 (8)