[LinuxCNC/linuxcnc PR#33] Stepconf porting to gtk3

#1 – jepler 于 2016-04-23

@c-morley any comments?

#2 – nicokid 于 2016-04-24

Is seems there is not much interest in the stepconf…

#3 – jepler 于 2016-06-12

@nicokid how would you rate your long-term interest in maintaining stepconf? You’re right that no current dev seems too interested in working on it, but I know many users use it for initial setup, so it would be a pity to see it go out of date with gtk2.

#4 – nicokid 于 2016-06-14

My gtk3 version of stepconf is already working, but for sure there will be some bugs that I have not discovered.
Right now I’m fighting with heekscnc so I temporarily put aside stepconf, but I’m going to make some other changes. I’m not a real programmer and I have a small python experience. So I don’t have enough skills to maintaining stepconf but I can help.
Like you I too consider essential stepconf to start using LinuxCNC. Otherwise, the learning curve is too steep and would discourage anyone.

#5 – jepler 于 2016-06-14

I should ask my question more plainly: Would you consider becoming a de-facto maintainer of stepconf, which means things like responding to stepconf issues and pull requests on github and participating to help with users of stepconf either the mailing list or the forum? The past maintainers of stepconf are putting their energies into other projects at the moment, and I don’t think we have anybody who is familiar with gtk3 in any case. So the “job” is yours if you want it, and I believe the project would benefit from having your participation.

#6 – nicokid 于 2016-06-14

Hi Jeff,
in truth, I realized that was missing a maintainer. For the issues I can do something, I have seen that there is only one it right now. As for the forum and the mailing list I can not respond to all requests due to my bad English, and of course the lack of time.
In summary:
1) Solve issue: yes
2) Pull request: yes
3) Help stepconf users in the mailing list or the forum: no
Do you consider this job enough?

#7 – jepler 于 2016-06-14

Your english has been perfectly clear while discussing this issue. But I understand if you are reluctant to offer help on the forum for this reason.

@mozmck @c-morley with @nicokid offering to help maintain stepconf in a continuing fashion, any concerns about merging this pull request?

#8 – jepler 于 2016-06-14

Besides the problem I noted in the “Mio commento” commit, there’s one other important thing to take care of before. It is called the “signed-off-by” policy, and it is described here: https://github.com/LinuxCNC/linuxcnc/blob/master/docs/SubmittingPatches — basically, it is your promise to the project that your contribution is under an appropriate open source license.

With your permission, I can add this line to the commit message of all the commits in your pull request, or I can teach you about how to do it using git rebase. In the future, you can add it yourself by using git commit -s or if you use a graphical tool like git gui, you can click its “sign off” button for each commit.

#9 – nicokid 于 2016-06-15

Hi Jeff,
I tried to sign-off all commits with rebase, but I do not know what I’ve done…I looked at this post:
http://stackoverflow.com/questions/25570947/how-to-use-git-interactive-rebase-for-signing-off-a-series-of-commits
Tell me if it’s okay. From now on I will use ‘-s’ in all commits.
I also removed my branch “halui” because it is already integrated into my master.
I’m sorry but I have great difficulty with git, I always used only subversion.

#10 – jepler 于 2016-06-15

@nicokid, Thank you for giving it a try. I agree, some parts of git take time to learn. But I think you’ll become comfortable with it with time.

I will look at the latest changes for this pull request in detail soon.

#11 – jepler 于 2016-06-17

@nicokid when you get a chance, please look at #71 where I’ve fixed the signed-off-by for you. If that looks OK to you, I am prepared to merge it into our master branch.

#12 – nicokid 于 2016-06-19

Your jepler/master/nicokid-stepconf still that based on gtk2. At least that’s what I believe.

#13 – jepler 于 2016-06-20

@nicokid what do you see that makes you believe my branch is still based on gtk2? I ran my branch and your branch and they look the same, and they look different than our “master” branch.
!different

#14 – nicokid 于 2016-06-20

Sorry but I I’m always confused with git. I looked at this link, here there is the old version:
https://github.com/LinuxCNC/linuxcnc/tree/jepler/master/nicokid-stepconf

But in fact here are the changes for gtk3:
https://github.com/LinuxCNC/linuxcnc/pull/71/files

#15 – jepler 于 2016-06-21

Thanks for double checking. git can be tough for new users, and some of the ways we ask contributors to use git require even more knowledge.

#16 – jepler 于 2016-06-22

Thanks for your contribution to LinuxCNC. I hope you’ll be able to help us out more with stepconf and gtk3 porting in general in the future!

#17 – nicokid 于 2016-06-22

Hi Jeff,
I do not know why, but some files of the master branch still to be in gtk2:
axisa.glade, axisx.glade, axisy.glade, axisz.glade.

#18 – jepler 于 2016-06-25

I believe you are correct. I can see this by searching our source tree.

$ git grep '
src/emc/usr_intf/stepconf/axisx.glade:  
src/emc/usr_intf/stepconf/axisy.glade:  
src/emc/usr_intf/stepconf/axisz.glade:  

this may be my error when I created #71. Can you help me with fixing it?

#19 – nicokid 于 2016-06-27

My repository is correct:
https://github.com/nicokid/linuxcnc.git
Maybe you can just do a merge?

#20 – jepler 于 2016-06-27

I can’t directly take your branch because of the boring technical reason that not all the commits in your branch have the “signed-off-by” message. But when preparing #71 to fix that problem, I was not careful enough.

I have now made an additional commit on our master branch which take the contents of the “axis[xyza].glade” files exactly as they are in this pull request. Can you check our master branch and see if it’s right now?

#21 – nicokid 于 2016-06-28

You must also do the update of axisu.glade and axisv.glade.