[LinuxCNC/linuxcnc PR#283] (`statetags` branch) Restore G61/G61.1/G64 state after abort

未分类 bolang 4个月前 (10-15) 26次浏览

Issue #283 | 状态: 已关闭 | 作者: zultron | 创建时间: 2017-06-16


This PR is against the statetags branch as part of #134

– Restore motion mode and G64 tolerances after abort; fix for issue #177
– Also convert G64 tolerances at G20/G21
– Also save/restore naive CAM tolerance at indexing and canned cycles
– Make G64 tolerances available via python status.settings[3:5]
– Add regression test demonstrating #177 and testing this work
– Fix a couple of bugs in the statetags tree


评论 (7)

#1 – jepler 于 2017-06-17

The travis-ci build bug should be fixed by 5ce31592ef904e7f9b37691357cb86e62c667100. If this branch is from before that commit (it appears to be) then travis-ci builds will fail. it should not block acceptance of this PR, though I encourage to arrange for travis-ci or buildbot to test the result of merging this with master before it is accepted.


#2 – zultron 于 2017-06-20

Thanks for the hot tip, @jepler. The build is passing.


#3 – zultron 于 2017-06-20

@robEllenberg


#4 – c-morley 于 2018-09-03

@zultron Hey Is this still relevant? i would like to get staetags rolling again.


#5 – zultron 于 2018-09-04

Hi @c-morley,

Yes, this is the next PR I’m going to work on. This PR is missing some new work I did that also updates state tags after non-motion commands and fixes status buffer getting out of synch at e.g. M01 after a G21 was issued but no following motion updated status. I’ll add that when I get a bit of time, hopefully the next few weeks.

Like the M98/M99 stuff, this has been in Tormach’s tree for quite some time now, and is even more well-tested, since it gets used every time a program runs.

I believe this already have some interest in the LCNC community. Aside from yours above (thanks!), @SebKuzminsky and @cradek have inquired about this off-line.

And of course I’m happy to be its maintainer!


#6 – gmoccapy 于 2019-08-07

Will this be merged soon? I hope so.

Norbert


#7 – andypugh 于 2020-03-28

I guess there is no reason not to merge this to Statetags?


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/283

喜欢 (0)