[LinuxCNC/linuxcnc PR#270] axis: default touchoff coordinate system

未分类 bolang 4个月前 (10-15) 24次浏览

Issue #270 | 状态: 已关闭 | 作者: phillc54 | 创建时间: 2017-05-16


set default touchoff coordinate system to the currently active coordinate system
see issue #61

Signed-off-by: Phillip Carter

Make sure you can check all these boxes before submitting your issue—Thank you!

– [] The submitted code is available under the GNU GPL version 2 with the “or later” clause
– [] You have certified that this is the case by including a “Signed-off-by” message in each commit
– [] You used your real name and a working e-mail address in this message

[you can delete this text before submitting your issue]


评论 (2)

#1 – jepler 于 2017-05-18

Before this change, you can touch off several axes in the non-active coordinate system, because the user’s change to the “coordinate system” dropdown sticks from one touch off to the next.

After this change, even if the user selects a different “coordinate system” from the dropdown, the next touch off will start with the active coordinate system selected instead.

It’s possible that the new proposed behavior is better than the old, but if it is then the now-useless line should be removed from touchoffsystem, as this pseudo-patch suggests:
~~~~
savetaskmode = s.task_mode
+ vars.touchoffsystem.set(system)
ensuremode(linuxcnc.MODEMDI)
~~~~

A more comprehensive approach might make “Current system” its own item in the pull-down, so that when a user selects a different system manually, their selection sticks as now; but a user who always prefers to touch off in the current system can get that behavior too. As noted in the conversation on the linked issue, this is not too hard to do, since P0 names the current system. In fact, I implemented this as PR #272, so can you see whether this scratches your itch?


#2 – phillc54 于 2017-05-19

#272 does this much better…


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/270

喜欢 (0)