[LinuxCNC/linuxcnc PR#210] Adds G84/G74 Floating Tapping Cycles and Possibility to ignore Spindle_at_speed before feed move

未分类 bolang 4个月前 (10-15) 45次浏览

Issue #210 | 状态: 已关闭 | 作者: terkaa | 创建时间: 2016-11-16



评论 (6)

#1 – jepler 于 2016-11-16

I suggest moving the restores of the override state into the g74/g84-specific code:
d34932b97b2812d1246d67cccae44ccb66a2f73e

to behave properly under rs274 sai, the implementation of GETEXTERNALxxx_OVERRIDE needs to be fixed: b624266abc220ef55b32bfe86a2cc4191077d879


#2 – terkaa 于 2016-11-16

Issues should be fixed now


#3 – terkaa 于 2016-11-16

It seems I still have some work with Expected test…
Tomorrow


#4 – terkaa 于 2016-11-17

Fixed tests for these


#5 – terkaa 于 2016-11-17

Still fixed 2 failing tests


#6 – andypugh 于 2018-09-24

This has been hanging around a long time.
Looking through the code it looks like G74 and G84 are now supported, can this pull request be closed?


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/210

喜欢 (0)