[LinuxCNC/linuxcnc PR#161] Bugfix for stepconf

未分类 bolang 4个月前 (10-15) 24次浏览

Issue #161 | 状态: 已关闭 | 作者: nicokid | 创建时间: 2016-09-09


Resolve some issues on stepconf:
– #86 entry fields blank on stepconf axis pages
– #57 stepconf in 2.7.4 “axis test” popup forgets Velocity and Acceleration settings
– some minor bugfix.


评论 (7)

#1 – nicokid 于 2016-09-11

Fixed the mistake when saving as string the axis values for test. (Sorry).


#2 – jepler 于 2016-09-11

Hello @nicokid and thanks for working on these stepconf issues. Issue #57 does seem to be fixed, :+1:

Unfortunately, testing with these changes at d6fad81 I still see the problem described in issue #86

!issue86

Tested on a Debian Jessie system with the XFCE desktop environment.


#3 – nicokid 于 2016-09-12

I changed the code so as to retain the original background color and change it to red only if an error occurs. I think a more efficient way.
Please verify if it works. Thanks.


#4 – nicokid 于 2016-09-12

I forgot to add the style. Sorry I still little familiarity with git.
Nicola.


#5 – jepler 于 2017-05-10

Many of these commits, such as 17f4335, do not follow our signed-off-by policy. Please create a fresh pull request where all commits follow the policy.


#6 – nicokid 于 2017-05-15

Hi Jeff,
At this time I am confused, I and Git do not agree with each other. This is frustrating…
I tried this command in my local copy:
git commit --amend --signoff
And in the end I destroyed my source code…

So I cloned again the copy in my repository:
git clone https://github.com/nicokid/linuxcnc.git linuxcnc-nicokid

Now git branch report only master. And git fetch upstream report:
fatal: ‘upstream’ does not appear to be a git repository
fatal: The remote end hung up unexpectedly

I need help. Thanks.
Nicola.


#7 – nicokid 于 2017-05-22

Ok, I got it all right.


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/161

喜欢 (0)