[LinuxCNC/linuxcnc PR#16] add support for ‘.tcl’ files set by [HAL]POSTGUI_HALFILE

未分类 bolang 4个月前 (10-15) 24次浏览

Issue #16 | 状态: 已关闭 | 作者: ikcalB | 创建时间: 2015-09-03


Signed off by: Florian Kerle flo.kerle@gmx.at


评论 (3)

#1 – jepler 于 2015-09-03

Unfortunately, I encounter errors during the build process after applying your changes. It appears that you are missing the “:” needed after “else”.

Traceback (most recent call last):
File ““, line 1, in
File “emc/usr_intf/touchy/touchy.py”, line 841
else
^
SyntaxError: invalid syntax
emc/usr_intf/touchy/Submakefile:25: recipe for target ‘../bin/touchy’ failed
make: *\ [../bin/touchy] Error 1
make: *\ Waiting for unfinished jobs….
Traceback (most recent call last):
File ““, line 1, in
File “emc/usr_intf/axis/scripts/axis.py”, line 3382
else
^
SyntaxError: invalid syntax
emc/usr_intf/axis/Submakefile:37: recipe for target ‘../bin/axis’ failed
make: *\ [../bin/axis] Error 1
Traceback (most recent call last):
File ““, line 1, in
File “emc/usr_intf/gscreen/gscreen.py”, line 3696
else
^
SyntaxError: invalid syntax
emc/usr_intf/gscreen/Submakefile:32: recipe for target ‘../bin/gscreen’ failed
make: *\ [../bin/gscreen] Error 1
Traceback (most recent call last):
File ““, line 1, in
File “emc/usr_intf/gmoccapy/gmoccapy.py”, line 4311
else
^
SyntaxError: invalid syntax
emc/usr_intf/gmoccapy/Submakefile:26: recipe for target ‘../bin/gmoccapy’ failed
make: *\ [../bin/gmoccapy] Error 1


#2 – jepler 于 2015-09-03

I fixed the else: problem and also corrected the Signed-off-by line (which should have hyphens, not spaces). Your contribution is now in the linuxcnc 2.7 branch. Congratulations on your first contribution to LinuxCNC.


#3 – ikcalB 于 2015-09-04

First: Thank you for your support!

New to git, wanted to roll back some stub commits, then had to diff & patch to 2.7 branch. looks like i rolled back too many commits…
In the future, I’ll check the build AFTER i pushed and BEFORE i send a pull request


原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/16

喜欢 (0)