[LinuxCNC/linuxcnc PR#135] Execute finish in py remap lcnc About GRBL HAL

Issue #135 | 状态: 已关闭 | 作者: zultron | 创建时间: 2016-08-10

A couple of folks have asked for reentrant python remap functions, or generators, where yield INTERPEXECUTEFINISH returns control to task, and the next read/execute cycle returns control back to the remap function. This is useful for complex remaps, such as tool changers that need to coordinate G code motion with external HAL components.

@mhaberler put in all the basic infrastructure to do this in the original remap implementation. These patches are just a few tweaks to get it working again, plus a unit test.

#1 – zultron 于 2016-08-10

Assuming the project is interested in merging this fix, should the PR be against the master branch (as here) or 2.6, where remap was introduced?

#2 – jepler 于 2016-08-10

@zultron 2.6 and 2.7 are mature branches, and so should only receive very safe fixes for things that are clearly regressions. Personally, I wouldn’t try to do this in any branch older than master.

#3 – jepler 于 2016-08-10

Buildbot is working now, you will be able to view results at http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/4456

#4 – cradek 于 2016-08-16

@zultron Thank you for your continuing work on remap.

原始Issue: https://github.com/LinuxCNC/linuxcnc/pull/135

评论 (4)