[LinuxCNC/linuxcnc Issue#655] Motors left enabled after inversekinematics fail About GRBL HAL

Issue #655 | 状态: 已关闭 | 作者: ftkalcevic | 创建时间: 2019-10-24

Whenever there is an kinematicsInverse error, axis appears to stop, but joint.n.amp-enable is still TRUE. This is on master.

This appears to be a bug in emc/motion/control.c getposcmds(). If an error occurs, emcmotDebug->enabling is set to 0, and SETMOTIONENABLE_FLAG(0) is called.

This call to SETMOTIONENABLEFLAG shouldn’t be made. This is done automatically in setoperatingmode(). Setting the flags causes setoperating_mode() to not work correctly.

SETMOTIONENABLEFLAG(0) is called 4 times in getpos_cmds(). They should all be deleted.
(Sorry – my github fork is broken, otherwise I would have submitted a pull request)

#1 – andypugh 于 2020-01-15

I have had this sat in my inbox since October, and have been meaning to have a look at it.
(This is just to say that this hasn’t been entirely lost from consideration)

#2 – andypugh 于 2020-03-23

Addressed by 252e2899f9611f4f1cc79dd9135991e97c8de4d8

原始Issue: https://github.com/LinuxCNC/linuxcnc/issues/655

评论 (2)