评论 (6)
#2 – mozmck 于 2019-07-12
I think he wants us to review PR #619
I just set my review to approved, but it wouldn’t hurt if you could look at it.
#3 – robEllenberg 于 2019-07-12
@mozmck exactly, it would be nice to have more eyes on it as a sanity check.
#4 – andypugh 于 2019-07-12
I can barely read C++ ![]()
Plain C and Python (and, irrelevantly) VBA are the ones that I can just read and understand.
#5 – mozmck 于 2019-08-05
@robEllenberg; can we close this issue now that the PR was merged?
#6 – robEllenberg 于 2019-08-05
Yes, I have some additional tests to merge in the future, but everything we need to write tests is in place now.
#1 – andypugh 于 2019-07-12
I am sure that these are a good idea. Do you need anything from the rest of us?