[LinuxCNC/linuxcnc Issue#609] Bug by inspection in halui.cc

未分类 bolang 5个月前 (10-15) 22次浏览

Issue #609 | 状态: 已关闭 | 作者: andypugh | 创建时间: 2019-06-12


The halui.axis.jog-selected pin is kept in the top slot of the array:


ARRAY(halbitt,ajogminus,EMCMOTMAX_AXIS+1) / pin to jog in positive direction / \
...
retval = halpinbitnewf(HALIN, &(haluidata->ajogplus[EMCMOTMAXAXIS]), comp_id, "halui.axis.selected.plus");
`

But the code seems to look in the "num_axes" slot, which is derived from [TRAJ]COORDINATES and is typically < 9. `
} else {
*(haluidata->axisisselected[axisnum]) = 1;
if (*haluidata->ajogplus[num_axes]) {
sendJogCont(axisnum, newhaluidata.ajogspeed,JOGTELEOP);
} else if (*haluidata->ajogminus[num_axes]) {
sendJogCont(axisnum, -newhaluidata.ajogspeed,JOGTELEOP);
}

``

If [TRAJ]COORDINATES is omitted then the code explicitly sets numaxes = EMCMOTMAX_AXIS but otherwise I do not think that it does,


评论 (2)

#1 - andypugh 于 2019-06-13

Introduced by 69aa9e65d40f1b0470d26748a5db4ff8a324777a
Can you have a look to see if you agree with my assessment above, Seb?


#2 - andypugh 于 2019-09-21

Seems to work in practice.


原始Issue: https://github.com/LinuxCNC/linuxcnc/issues/609

喜欢 (0)