[LinuxCNC/linuxcnc Issue#582] INI parameter access in G-Code About GRBL HAL

Issue #582 | 状态: 已关闭 | 作者: Eranziel | 创建时间: 2019-05-06

Here are the steps I follow to reproduce the issue:

1. Create a .ngc file which reads an INI file parameter using #<_ini[section]name>.
2. Try to run the file.

Here’s a simple example:
“# = #<ini[axisx]min_limit> g0 #

M2`


This is what I expected to happen:

#<ini[axisx]min_limit> should return the value from the INI file. In this case, 0.0.


This is what happened instead:

Interpreter gives the following error:`G-Code error in temp.ngc Near line 2 of /home/user/linuxcnc/nc_files/temp.ngc Named parameter #<ini[axisx]min_limit> not defined“

This functionality is mentioned in the devel docs. The note at the bottom of the section implies it was part of a branch – either the functionality should be merged into master (my personal preference), or the documentation removed.

#1 – andypugh 于 2019-05-06

Have you enabled the feature using the FEATURE_MASK described in section 18?

http://linuxcnc.org/docs/devel/html/remap/remap.html#optionalinterpreterfeaturesinifileconfiguration

#2 – zultron 于 2019-05-07

The confusing comment @Eranziel refers to is also in the [2.7 documentation][1]:

> Caution | this section doesn’t really belong here but since it comes with the same branch, here it rests for now until its clear this will be merged. It should go into the gcode/overview Named Parameters section.

It looks like something that wasn’t caught during review.

It would make good sense to explicitly note this is an experimental feature and add a pointer to section 18 for how to enable it.

[1]: http://linuxcnc.org/docs/2.7/html/remap/remap.html#remap:referto-inifile-variables

#3 – andypugh 于 2019-05-07

I can also see little reason for it not to default to “on”
I am more wary of doing that with HAL pin values.

#4 – SebKuzminsky 于 2019-05-07

FWIW I agree with @andypugh. As far as possible let’s try to have a single set of features, always on.

#5 – Eranziel 于 2019-05-07

Well, I completely missed that when I read section 18, my mistake.

However, I’ve now added FEATURES = 8 to the RS274NGC section and I get the same result. Can anyone else confirm?

FWIW, my personal preference would be to default that feature to ON as well. I may or may not be biased by currently working on a project where I want to use it…

#6 – andypugh 于 2019-05-07

It’s 4 to turn on INI parameter access, and 8 to turn on HAL pin access.
(or 12 to make sure and turn on both)

#7 – Eranziel 于 2019-05-07

Total reading comprehension fail there, my bad. It does work when you turn it on.