[LinuxCNC/linuxcnc Issue#49] 2.6: abort during startup interrupts startup

#1 – SebKuzminsky 于 2016-06-06

Jeff and I discussed a possible fix here:
http://tom-itx.no-ip.biz:81/~tom-itx/irc/logs/%23linuxcnc-devel/2016-06-06.html#09:42:01

#2 – zultron 于 2016-06-13

Seb, I’ve verified the fix for 2.6. Nice work!

I picked the commits into another tree I’m working on, and everything works except status.gcodes isn’t updated. This actually causes the statbuffer-g5x-abort test to fail in that tree. Running any MDI command (even (foo)) causes status.gcodes to be updated, though, so it looks like it should be something easy.

If you hold off on merging this a few days, I’ll try and fix that problem, and will let you know if it’s somehow relevant to LCNC, even though it looks like it isn’t at this point.

#3 – SebKuzminsky 于 2016-06-14

Ok, i’ll hold off until I hear from you. Thanks for testing it.

#4 – zultron 于 2016-06-16

@SebKuzminsky, this is looking great. The issue I had was related to the state tags work, so it doesn’t apply to LinuxCNC. I really appreciate the fix!

#5 – SebKuzminsky 于 2016-06-16

Thanks for looking into it and letting me know, i just pushed this to our 2.6 branch.

#6 – zultron 于 2017-12-07

The fix for this particular issue (abort during task init) was in 402c27b, but was reverted in 9f07c33. The corresponding regression test motion-logger/startup-gcode-abort was disabled in bdffc97.

I’m almost done with some updates to the state tags branch that make a lot of improvements, and while I was at it, cherry-picked 402c27b back onto it, and the test seems to pass again.

I wonder if this one shouldn’t be reopened until it’s actually fixed (an org member will have to do it). Otherwise I’ll start a new issue pointing here.

#7 – andypugh 于 2017-12-07

Issue re-opened as requested

#8 – zultron 于 2020-05-19

State tags has been merged into master at this point. I believe this issue is no longer outstanding, or to the extent that it is, it is superseded by #858, tracking intermittent failures in motion-logger/startup-gcode-abort test.