[LinuxCNC/linuxcnc Issue#422] HAL gladevcp Iconview widget – Coding error

Small things can bug me a little because you never know if these small things will lead to other more serious issues later. I decided to look at why my gmoccapy always reports an error at start up, Invalid icon size 48. Not a big issue but still a problem that needs to be fixed. One of the causes for this is that Hal GladeVCP iconview.py has a programming error and thus more than just gmoccapy reports can show this error in its printed log.

Here is my description of the issue with Hal GladeVCP iconview.py and a simple suggestion for a fix.

Withing the iconview.py are 9 lines like:

“image.setfromstock(gtk.STOCKGOTOTOP, 48)”

The 48 is supposed to refer to the displayed file folders icons desired size. This cannot be done with entering 48 in these lines.
In these lines size is looking for a “name” that has defined an icon and “not a size number”.

Per the gtk Class Reference for gtk.Image, the normal allowed things for unless a custom one is made are:

gtk.ICONSIZEMENU
gtk.ICONSIZESMALL_TOOLBAR
gtk.ICONSIZELARGE_TOOLBAR
gtk.ICONSIZEBUTTON
gtk.ICONSIZEDND
gtk.ICONSIZEDIALOG.

Here are my suggested changes to consider to the Hal GladeVCP iconview.py widget:

Leave this line alone:
self.icon_size = 48 # The actual per file folder display size – must agree with the named item standard size definitions. A error in choosing the wrong size here will show wrong folder colors since that size is not likely defined as being possible in the named STOCK item definition.

Ok now for the suggested changes:

Add this line:
stksize = gtk.ICONSIZEMENU # GTK standard size name # chosen at random

Change 9 lines from and to list:
image.setfromstock(gtk.STOCK_HOME,48)
image.setfromstock(gtk.STOCK_HOME, stksize)

image.setfromstock(gtk.STOCKGOTOTOP,48)
image.setfromstock(gtk.STOCKGOTOTOP,stksize)

mage.setfromstock(gtk.STOCKGOBACK,48)
image.setfromstock(gtk.STOCKGOBACK, stksize)

image.setfromstock(gtk.STOCKGOFORWARD,48)
image.setfromstock(gtk.STOCKGOFORWARD, stksize)

#image.setfromstock(gtk.STOCKGODOWN,48)
#image.setfromstock(gtk.STOCKGODOWN, stksize)

#image.setfromstock(gtk.STOCKGOUP,48)
#image.setfromstock(gtk.STOCKGOUP, stksize)

image.setfromstock(gtk.STOCKJUMPTO,48)
image.setfromstock(gtk.STOCKJUMPTO, stksize)

image.setfromstock(gtk.STOCK_OK,48)
image.setfromstock(gtk.STOCK_OK, stksize)

image.setfromstock(gtk.STOCK_STOP,48)
image.setfromstock(gtk.STOCK_STOP, stksize)

This eliminates the Invalid icon size 48 error message generated by this widget.
I have seen similar errors in the past from at least one other file but cant recall its name.