[LinuxCNC/linuxcnc Issue#343] Apparent bug by inspection in mesa-hostmot2/encoder.c:hm2_encoder_read_control_register

未分类 bolang 4个月前 (10-15) 24次浏览

Issue #343 | 状态: 已关闭 | 作者: jepler | 创建时间: 2017-10-25

标签: hostmot2


The code is attempting to track the prior value of quad-error-enable. However, it does this by a single static value lasterrorenable. It looks like if not all encoders have the same quad-error-enable value, it won’t work properly, possibly leading to errors occurring and not being reported.

In particular, imagine a setup with 2 channels. channel 0 has quad-error-enable TRUE and channel 1 has quad-error-enable FALSE. Each time channel 0 is handled in the for-loop, lasterrorenable will be 0 because it was set the previous cycle when channel 1 was handled.


评论 (1)

#1 – andypugh 于 2019-06-19

Fixed by 2334748708de6bacfac3fa284aafec9289906154


原始Issue: https://github.com/LinuxCNC/linuxcnc/issues/343

喜欢 (0)