[LinuxCNC/linuxcnc Issue#277] Mesa digital filters for UART

未分类 bolang 4个月前 (10-15) 24次浏览

Issue #277 | 状态: 已关闭 | 作者: sirop | 创建时间: 2017-05-28


Hello,

would you accept such a patch https://github.com/machinekit/machinekit/pull/1212 into linuxcnc?

Any objections?


评论 (2)

#1 – jepler 于 2017-05-28

Please file a pull request. Remember the commits must conform to our signed-off-by policy.

Is there some reason to put this as a flag in the public API, vs just enabling it unconditionally?


#2 – sirop 于 2017-05-28

In rare cases the theoretical bittime might deviate from the real one, for instance, due to temperature dependency of the TTL converter. Then letting the user calculate a deviating FilterReg value might help.

But I’d rather ask PCW about it.


原始Issue: https://github.com/LinuxCNC/linuxcnc/issues/277

喜欢 (0)