[LinuxCNC/linuxcnc Issue#238] hm2_7i90 and hm2_7i43 drivers fail silently with null config string

#1 – andypugh 于 2017-03-06

Is this simply due to this bit of code?

for (i = 0; i < HM27I43MAX_BOARDS; i ++) {
if(!config[i] || !*config[i]) break;

If there is no config string, it just exits.

#2 – SebKuzminsky 于 2017-03-06

Yeah that looks pretty suspicious.

#3 – andypugh 于 2017-03-07

It looks like hm2_register does exactly the right thing with a null configuration string, so I rather suspect we can simply ignore that test.
It isn’t immediately obvious how you would pass a blank config to more than one board. But that’s a corner-case.
I sold my 7i43-powered machine, so I can’t actually test the change.

#4 – andypugh 于 2017-04-04

@pcw-mesa Are you able to test this change?

#5 – pcw-mesa 于 2017-04-04

Yes, I can test this later today.

#6 – andypugh 于 2017-08-08

PCW. Did you test this change?

#7 – pcw-mesa 于 2017-08-08

Ack I’ve forgotten if I did or not, My test LinuxCNC CPU with a parallel port is still in a box after moving
I’ll dig it out and try it again

#8 – pcw-mesa 于 2017-08-08

The error is still there (todays master) at least with the 7i90

#9 – andypugh 于 2017-08-08

Nothing has been changed yet. Are you in a position to compile LinuxCNC?

#10 – pcw-mesa 于 2017-08-08

yes

#11 – andypugh 于 2017-08-08

Can you try it after deleting the ” if(!config[i] || !*config[i]) break;” and then recompiling?
I think we need to test that an empty config string does start the card, and that a non-emptly one still works.

#12 – pcw-mesa 于 2017-08-08

config[i] no longer exists in the current source

#13 – andypugh 于 2017-08-10

I just pushed a fix to the 2.7 branch. It would be good to test with actual hardware, but I am confident that it works.

#14 – pcw-mesa 于 2017-08-10

I’ll test this either later today or tommorow

#15 – pcw-mesa 于 2017-08-11

Well it loads the driver now with a null config string but goes off into the weeds, trying to access a second card (the 7I90.1) (with a config string or not):

hm2/hm2_7i90.0: IO Pin 070 (P3-45): IOPort
hm2/hm2_7i90.0: IO Pin 071 (P3-47): IOPort
hm2/hm2_7i90.0: registered
hm27i90.0: board at (ioaddr=0x0378, ioaddrhi=0x0778, epp_wide ON) found
Linux parallel port @632 not found
hm2_7i90: failed to clear EPP Timeout!
hm2: no firmware specified in config modparam! the board had better have firmware configured already, or this won’t work
hm2_7i90.1: EPP timeout on data cycle of read(addr=0x0100, size=4)
hm2_7i90: failed to clear EPP Timeout!
hm2/hm2_7i90.1: error reading hm2 cookie
hm27i90.1: board at (ioaddr=0x0278, ioaddrhi=0x0000, epp_wide ON) not found!
hm2_7i90.0: releasing board
hm2/hm2_7i90.0: unregistered
hm27i90: rtapiappmain: Input/output error (-5)hm2/hm27i90.0: IO Pin 070 (P3-45): IOPort
hm2/hm2_7i90.0: IO Pin 071 (P3-47): IOPort
hm2/hm2_7i90.0: registered
hm27i90.0: board at (ioaddr=0x0378, ioaddrhi=0x0778, epp_wide ON) found
Linux parallel port @632 not found
hm2_7i90: failed to clear EPP Timeout!
hm2: no firmware specified in config modparam! the board had better have firmware configured already, or this won’t work
hm2_7i90.1: EPP timeout on data cycle of read(abut now with a config string or not it goes off into the weeds, trying to access a second card (the 7I90.1):ddr=0x0100, size=4)
hm2_7i90: failed to clear EPP Timeout!
hm2/hm2_7i90.1: error reading hm2 cookie
hm27i90.1: board at (ioaddr=0x0278, ioaddrhi=0x0000, epp_wide ON) not found!
hm2_7i90.0: releasing board
hm2/hm2_7i90.0: unregistered
hm27i90: rtapiapp_main: Input/output error (-5)
:2: waitpid failed /home/pcw/linuxcnc-dev/bin/rtapiapp hm27i90
:2: /home/pcw/linuxcnc-dev/bin/rtapi_app exited without becoming ready
:2: insmod for hm2_7i90 failed, returned -1

:2: waitpid failed /home/pcw/linuxcnc-dev/bin/rtapiapp hm27i90
:2: /home/pcw/linuxcnc-dev/bin/rtapi_app exited without becoming ready
:2: insmod for hm2_7i90 failed, returned -1

#16 – andypugh 于 2017-08-11

Do you have a port address of 0x632 specified, or is that bogus?

#17 – pcw-mesa 于 2017-08-11

Its bogus

#18 – pcw-mesa 于 2017-08-11

That is, with a null config string it looks like it finds the (one) 7I90 I have connected
at the Default 0x378 address, then goes on to try the next standard parallel port address
(0x278 = 632). Master works as expected (and still silently fails when no config string is present)

#19 – andypugh 于 2017-10-10

I have pushed a new fix. It works here with both a single 7i43 and a single 7i90.
I don’t see any reason for it not to work with multiples of either, but lacked the hardware to check.