[gnea/grbl-Mega PR#68] Fixes gremlin where changing step and direction inversion masks made a mess

未分类 bolang 3周前 (10-15) 5次浏览 0个评论

Issue #68 | 状态: 已关闭 | 作者: bgort | 创建时间: 2018-08-10


This PR fixes a gremlin where changing the stepper step and direction inversion masks didn’t work correctly because stepportinvertmask[] and dirportinvertmask[] (new with the RAMPS modifications) weren’t reset to 0 when they should have been (when unset).

This made initial setup more difficult due to likely desynchronization between settings.stepinvertmask and stepportinvertmask[] and between settings.dirinvertmask and dirportinvertmask[] with a change to $2 or $3, where grbl would ultimately behave as though there was always an inversion.

(Also, while I might have used a ternary to fix this, the way I did it seemed most consistent with grbl style. Please advise if you’d rather a ternary – easy fix.)


评论 (2)

#1 – chamnit 于 2018-08-10

Thanks.


#2 – bgort 于 2018-08-10

No problem.


原始Issue: https://github.com/gnea/grbl-Mega/pull/68

喜欢 (0)
发表我的评论
取消评论
表情 贴图 加粗 删除线 居中 斜体 签到

Hi,您需要填写昵称和邮箱!

  • 昵称 (必填)
  • 邮箱 (必填)
  • 网址