[gnea/grbl-Mega PR#159] Improve checksum per https://github.com/gnea/grbl-Mega/issues/158

未分类 bolang 4个月前 (10-15) 26次浏览

Issue #159 | 状态: 进行中 | 作者: drf5n | 创建时间: 2022-04-11


Per https://github.com/gnea/grbl-Mega/issues/158 The logical OR squashes the previous checksum down to 1 bit of information, resulting in the final checksum being either the last character written, or one plus the last character written.

This change switches to the bitwise-or to convert the squashing into a 1-bit roll to the left.


评论 (2)

#1 – drf5n 于 2022-04-11

This would be consistent with grblHAL’s

https://github.com/grblHAL/core/blob/3a84b58d301f04279268b4ef1045fd6bc0961be5/nuts_bolts.c#L267-L278


#2 – fra589 于 2022-04-11

Very old subject… Already discussed in 2017 here :
https://github.com/grbl/grbl/issues/1249#issuecomment-569354273
with the choice not to correct it
@++;
Gauthier.


原始Issue: https://github.com/gnea/grbl-Mega/pull/159

喜欢 (0)