[PR#900] Update Spanish translation About GRBL HAL

Issue #900 | 状态: 已关闭 | 作者: hasecilu | 创建时间: 2025-01-07

标签: Review effort [1-5]: 2

User description

I’ll be testing next weeks to see if there is something else to fix.

I don’t like “spindle”, is “cabezal” the best option? Open to hear some reviews.

CC: @yeyeto2788

PR Type

Documentation, Enhancement

Description

– Updated Spanish translations for improved accuracy and consistency.

– Adjusted terminology in CNC-related terms for better clarity.

– Updated translation directory URLs in README.md.

– Added a new contributor to the Spanish translation team.

Changes walkthrough 📝

Relevant files

Documentation

README.md

Update translation directory URLs and contributors

README.md

Updated URLs for translation directories.

Added a new contributor for Spanish translations.

+14/-14

Enhancement

controller.json `Refine Spanish translations for controller states` src/app/i18n/es/controller.json Refined translations for CNC machine states. Improved terminology consistency (e.g., “stop” to “detener programa”).	+17/-17
gcode.json `Improve Spanish translations for G-code terms` src/app/i18n/es/gcode.json Adjusted G-code terminology for better clarity. Standardized capitalization and phrasing.	+21/-21
resource.json `Enhance and correct Spanish UI translations` src/app/i18n/es/resource.json Enhanced general UI translations for better user understanding. Fixed grammatical and typographical errors. Standardized phrasing across multiple entries.	+259/-259

> 💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

#1 – codesandbox[bot] 于 2025-01-07

#### Review or Edit in CodeSandbox

Open the branch in source=ghapp”>VS Code • source=ghapp”>Preview

#2 – codiumai-pr-agent-free[bot] 于 2025-01-08

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Translation Consistency

Some translations mix formal and informal pronouns (‘tu’ vs ‘usted’). Should standardize on one style throughout.

"Are you sure you want to load this macro?": "¿Está seguro de cargar esta macro?",
"No macros": "No hay Macros",
"Run": "Ejecutar",
"Get Extruder Temperature (M105)": "Obtener temperatura de extrusor (M105)",
"Get Current Position (M114)": "Obtener posición actual (M114)",
"Get Firmware Version and Capabilities (M115)": "Obtener versión de firmware y prestaciones (M115)",

Missing Translation

The string “Go To Work Zero On C Axis (G0 C0)” is left untranslated while similar strings for other axes are translated.

#3 – codiumai-pr-agent-free[bot] 于 2025-01-08

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Fix missing closing parenthesis in translation string to maintain proper JSON syntax _ Fix the missing closing parenthesis in the “P2 (G55)” translation key to maintain JSON structure integrity. [src/app/i18n/es/gcode.json [12]](https://github.com/cncjs/cncjs/pull/900/files#diff-2c6e804214b9aabec3414adf4ae2c97a62537efc61698fb4b1bbf6a41e420f9fR12-R12) `-"P2 (G55)": "P2 (G55", +"P2 (G55)": "P2 (G55)",` – [ ] Apply this suggestion Suggestion importance[1-10]: 9 Why: The missing closing parenthesis is a syntax error that could cause JSON parsing failures. This is a critical fix needed for proper functionality.	9
General	Fix grammatical error in Spanish error message translation _ Fix the grammatical error in the error message translation – “A ocurrido” should be “Ha ocurrido” to match proper Spanish grammar rules. [src/app/i18n/es/resource.json [44]](https://github.com/cncjs/cncjs/pull/900/files#diff-7bb82d1f047a31d3ca8900c381a868bf1b66d699219facf7611ff84714da82c0R44-R44) `-"An unexpected error has occurred.": "A ocurrido un error inesperado.", +"An unexpected error has occurred.": "Ha ocurrido un error inesperado.",` – [ ] Apply this suggestion Suggestion importance[1-10]: 7 Why: The correction from “A ocurrido” to “Ha ocurrido” fixes a significant grammatical error in Spanish that could affect user comprehension and the professional appearance of the interface.	7
	✅ Fix missing accent mark in Spanish affirmative word _ Suggestion Impact: The commit implemented the suggestion by using ‘Sí’ with accent mark for the Spanish translation of ‘OK’ code diff: `"OK": "Sí",` _ Fix typo in “OK” translation – “Si” should be “Sí” with an accent mark to match proper Spanish spelling. [src/app/i18n/es/resource.json [43]](https://github.com/cncjs/cncjs/pull/900/files#diff-7bb82d1f047a31d3ca8900c381a868bf1b66d699219facf7611ff84714da82c0R43-R43) `-"OK": "Si", +"OK": "Sí",` – [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: Adding the accent mark to “Sí” is important for correct Spanish orthography and maintains proper language standards in the interface.	6
	✅ Maintain consistent capitalization across all state translations _ Suggestion Impact: The sleep state translation was changed, but to ‘Suspender’ instead of ‘Dormir’ code diff: `- "sleep": "Dormir", + "sleep": "Suspender",` _ Capitalize “dormir” in the sleep state translation to maintain consistency with other state translations which all start with capital letters. [src/app/i18n/es/controller.json [27]](https://github.com/cncjs/cncjs/pull/900/files#diff-140e5622b76b48e9b5299b5b4c1ef9ac04ae8776e72a5b6bc53a863e95a9fd93R27-R27) `-"sleep": "dormir", +"sleep": "Dormir",` – [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: The inconsistent capitalization affects readability and maintainability. All other state translations in the file use capital letters, so this should follow the same convention.	6
	✅ Maintain consistent terminology translation across the interface _ Suggestion Impact: The commit implements the suggestion by consistently translating G-code to código G throughout the file code diff: - "G-code: Load": "Cargar G-code", - "G-code: Unload": "Subir G-code", - "G-code: Start": "Iniciar G-code", - "G-code: Stop": "Detener G-code", - "G-code: Pause": "Pausar G-code", - "G-code: Resume": "Resumir G-code", + "Close a serial port (System only)": "Cerrar puerto serie(Solo sistema)", + "G-code: Load": "Cargar código G", + "G-code: Unload": "Subir código G", + "G-code: Start": "Inciar código G", + "G-code: Stop": "Detener código G", + "G-code: Pause": "Pausar código G", + "G-code: Resume": "Reanudar código G", _ Fix inconsistent translation of “G-code” – it should be consistently translated as “código G” throughout the file to maintain terminology consistency. [src/app/i18n/es/resource.json [74-76]](https://github.com/cncjs/cncjs/pull/900/files#diff-7bb82d1f047a31d3ca8900c381a868bf1b66d699219facf7611ff84714da82c0R74-R76) `"G-code: Load": "Cargar código G", -"G-code: Start": "Inciar código G", +"G-code: Start": "Iniciar código G", "G-code": "Código G",` – [ ] Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion promotes consistency in terminology translation, but the existing translations are already consistent with “código G”, making this a less critical improvement.	5

#4 – yeyeto2788 于 2025-01-09

Hey @hasecilu!

IMHO cabezal is not bad but I have also seen it being translated/used into/as husillo but then it also give a second meaning as in can be interpreted as leadscrew.

We can also make use of something more generic as herramienta which might be better.

P.D: Sorry for the late reply.

#5 – cheton 于 2025-01-09

/ask Review the modified translation string in Spanish and identify if there are any issues.

#6 – codiumai-pr-agent-free[bot] 于 2025-01-09

Ask❓

Review the modified translation string in Spanish and identify if there are any issues.

Answer:

Looking at the modified Spanish translations, here are the key observations and issues:

1. Consistency Improvements:
– Better capitalization consistency (e.g., “Movimiento rápido” instead of “Movimiento Rápido”)
– More consistent terminology across similar terms
– Improved use of lowercase after colons

2. Terminology Refinements:
– More accurate technical translations
– Better clarity in CNC-specific terms
– Maintained “spindle” as technical term instead of translating it

3. Issues Found:
– Line 284: “Probe Z Axis” is incorrectly translated as “Sonda Eje-Y” – should be “Sonda Eje-Z”
– Line 463: “Go To Work Zero On C Axis (G0 C0)” is left untranslated while other similar strings are translated
– Last few entries (Data Collection related) are left in English and should be translated:

  "Data Collection": "Data Collection",
  "Enable anonymous usage data collection": "Enable anonymous usage data collection", 
  "Display language:": "Display language:"

Should be:

  "Data Collection": "Recolección de datos",
  "Enable anonymous usage data collection": "Habilitar recolección de datos anónimos",
  "Display language:": "Idioma de visualización:"

4. Improvements Made:
– Better handling of technical terms
– More natural Spanish phrasing
– Improved clarity in machine operation terms
– More consistent use of diacritical marks

Overall, while the translation quality has improved, there are a few overlooked items that should be addressed before merging.

#7 – hasecilu 于 2025-01-13

> IMHO cabezal is not bad but I have also seen it being translated/used into/as husillo but then it also give a second meaning as in can be interpreted as leadscrew.
>
> We can also make use of something more generic as herramienta which might be better.

Definitively “cabezal” it’s better than “husillo” but still something is missing. Let’s try herramienta to see if makes sense

#8 – hasecilu 于 2025-01-14

I’m testing on the UI, so I’ll be making changes for consistency. Hope to finish by the weekend.

#9 – hasecilu 于 2025-01-20

I thinks that’s all, I didn’t find more things to change.

#10 – cheton 于 2025-01-20

Thank you for your hard work on this. I will merge the PR shortly.

原始Issue: https://github.com/cncjs/cncjs/pull/900