[Grbl_Esp32 PR#747] fix soft limits for kinetics machines. fix corexy maths About GRBL HAL

Issue #747 | 状态: 已关闭 | 作者: dunkfordyce | 创建时间: 2021-01-20

Fixing soft limits for corexy. There was an issue here where values could get converted twice by the kinematics functions. By moving it to mclinekins the value has not yet been altered.

Fixing corexy maths. I found the maths was not quite right.

I have tested these fixes with UGS which now almost behaves completely properly (imho). There is one more issue where if you stop UGS executing a gcode file part way through, and then send a G0 message, the value is somehow caulculated wrong or something. I have always had this problem with grbl_esp32 so its nothing I have added. I hope to track it down soon.

#1 – bdring 于 2021-01-20

Thank you for the pull request. Could you please resubmit in accordance with our pull request guidelines.

We request all PRs target the Devt branch.

#2 – dunkfordyce 于 2021-01-20

Yes of course. Sorry I didnt check for that

On Wed, 20 Jan 2021 at 16:11, bdring wrote:

> Thank you for the pull request. Could you please resubmit in accordance
> with our pull request guidelines
> <https://github.com/bdring/Grbl_Esp32/wiki/Pull-Request-Guidelines#branches>
> .
>
> We request all PRs target the Devt branch.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bdring/Grbl_Esp32/pull/747#issuecomment-763742029>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA7YJB43THV7JQIOVQPZNDS236ETANCNFSM4WKXGZ3Q>
> .
>

#3 – bdring 于 2021-01-20

Also note, that there are some CoreXY changes pending in the AntFixes branch.

You can look at the commits to see what was done. There is still an issue recovering from a reset. You can see some discussion on this issue.

https://github.com/bdring/Grbl_Esp32/issues/715

#4 – dunkfordyce 于 2021-01-20

Ah yes I remember looking at this issue a while ago. It’s the same
conclusion as I currently have. I’m very determined to find it – its the
only thing left that makes my machine go clunk.

On Wed, 20 Jan 2021 at 17:33, bdring wrote:

> Also note, that there are some CoreXY changes pending in the AntFixes
> branch.
>
> You can look at the commits to see what was done. There is still an issue
> recovering from a reset. You can see some discussion on this issue.
>
> #715 <https://github.com/bdring/Grbl_Esp32/issues/715>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bdring/Grbl_Esp32/pull/747#issuecomment-763812450>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA7YJCBMJPR67W4TPRXNYDS24HWTANCNFSM4WKXGZ3Q>
> .
>

#5 – dunkfordyce 于 2021-01-20

@bdring Regarding the AntFix branch, whats the correct way to deal with it? Should I have a branch from devt that I then apply the ant fixes commits to, and then apply my fixes to?

#6 – bdring 于 2021-01-20

Probably the best way is to apply to AntFixes and that will be merged to Devt.

The only rule is all changes going to main must go through devt.

#7 – dunkfordyce 于 2021-01-20

Ok, thanks!

On Wed, 20 Jan 2021 at 18:37, bdring wrote:

> Probably the best way is to apply to AntFixes and that will be merged to
> Devt.
>
> The only rule is all changes going to main must go through devt.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bdring/Grbl_Esp32/pull/747#issuecomment-763850326>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA7YJEVWMO2S2IYQNXPADTS24PH3ANCNFSM4WKXGZ3Q>
> .
>

#8 – dunkfordyce 于 2021-01-21

Closing to do something better

原始Issue: https://github.com/bdring/Grbl_Esp32/pull/747

评论 (8)