[Grbl_Esp32 PR#626] Changed buffer sizes to 256 throughout various parts of the program.

未分类 bolang 5个月前 (10-14) 42次浏览

Issue #626 | 状态: 已关闭 | 作者: atlaste | 创建时间: 2020-10-05


Basically I changed the buffers to 256 bytes.

This is a patch necessary for F360 personal license users, because they decided to add a very lengthy comment.

NOTE: I’m in doubt about the Serial.setRxBufferSize(256); because I’m not sure how it would respond with multiple clients attached. Please advice.


评论 (2)

#1 – MitchBradley 于 2020-10-05

I think it is unnecessary since Autodesk has a fix in the works: https://forums.autodesk.com/t5/fusion-360-support/personal-use-version-takes-away-rapid-moves-and-makes-my-carbide/m-p/9783976/highlight/true#M101832


#2 – atlaste 于 2020-10-06

I’ve thought about it and yes, autodesk should fix their own mess. We fully agree on that one.

Still, even if its unnecessary for f360, it might still be good to consider this small patch, for the reason that the gcode standard supports 256, not 70, chars per line, as described in the comment. That means its only a matter of time, till the next sender uses over 70 chars for whatever reason.


原始Issue: https://github.com/bdring/Grbl_Esp32/pull/626

喜欢 (0)