[Grbl_Esp32 PR#512] Changed header guards to #pragma once form

未分类 bolang 4个月前 (10-14) 63次浏览

Issue #512 | 状态: 已关闭 | 作者: MitchBradley | 创建时间: 2020-08-07


In the Machines directory, also added
// clang-format off
because it will have to be done eventually and is safe,
so it was easy to do systematically during this edit.


评论 (1)

#1 – atlaste 于 2020-08-07

Checked. Found a few small things:

// clang-format off is not necessary in machine.h if include reordering is off. [PS: The machine include is incorrect btw, but let’s leave that one for later]
– BTConfig.cpp, InputBuffer.cpp, serial2socket.cpp, wikiservices.cpp, wikiconfig.cpp, webserver.cpp, telnetserver.cpp. #ifdef ARDUINOARCHESP32 . Probably want to remove that too; will give the same clangformat behavior as what we want to avoid.
– Please, delete print.*. There’s a serious conflict in InputBuffer that includes the wrong “print.h” (should be iirc) from ESP32. Let’s just get rid of it; it’s not used anyways and just makes things confusing at best. InputBuffer and serial2socket uses the incorrect include.
– Notifications service uses #ifdef ENABLE_NOTIFICATIONS. Same as above for BTConfig.
– Same for #ifdef USESERVOAXES in servo_axis.cpp/h
nofile.h sais in its comment that it’s generated. Is it (supposed to be) re-generated on f.ex. build? In that case we might not want to change it at all?
solenoidpen.cpp uses #ifdef USEPEN_SOLENOID


原始Issue: https://github.com/bdring/Grbl_Esp32/pull/512

喜欢 (0)