[Grbl_Esp32 PR#299] Fix: sync internal variables after kinematics_homing

未分类 bolang 4个月前 (10-14) 44次浏览

Issue #299 | 状态: 已关闭 | 作者: odaki | 创建时间: 2019-12-01


Hi, Bert-san.

Please merge my chages about kinematics homing.

1) After kinematics_homing, polar angle has increased (not synchronized). To correct this phenomenon, reset the internal value when the homing cycle is complete.

2) The kinematics_homing function should return True if it want to skip the subsequent homing process (according to comments in the source)

3) I thought that the homing function can be processed flexibly if it is executed before and after the original homing process.

4) Fix the Polar Coaster’s drawing being mirrored. (uncomment the code)

Thanks.


评论 (8)

#1 – bdring 于 2019-12-02

Thanks, that fixes a few things I had planned…and more. I will test in the next few days.

I have some changes coming to the midTbot too. They are primarily to fix the feed rate not being the same on X and Y.


#2 – bdring 于 2019-12-02

My images are inverted if I uncomment

C++
//targetxyz[XAXIS] *= -1.0; // compensate for Polar Coaster's radial axis being mirrored (right side) from normal 0deg
`

I also added ...

`C++
sysposition[ZAXIS] = SERVOZRANGEMAX * settings.stepspermm[ZAXIS]; // Move pen up.
`

to kinematicsprehoming`


#3 – odaki 于 2019-12-02

> My images are inverted if I uncomment
>
> “c++
> //targetxyz[XAXIS] *= -1.0; // compensate for Polar Coaster's radial axis being mirrored
>
`
Oh ... My machine may be different from your original.
I commented out again and set $ 3 to 1 (original 2). This worked as intended.
For my machine,
#define DEFAULTDIRECTIONINVERTMASK 2 // uint8t
should be
#define DEFAULTDIRECTIONINVERTMASK 1 // uint8t`


#4 – bdring 于 2019-12-02

I added one more feature. I have M30 at the end of my gcode. This uses it to move the pen to the side to allow coaster removal.

C++
// handle the M30 command
void user_m30() {
char gcode_line[20];
sprintf(gcodeline, "G53G0X-%3.2f\r", settings.homingpulloff); // go to the homing pulloff location to move pen out of the way
inputBuffer.push(gcode_line);
}
`

...needs #define USEM30` in cpumap.


#5 – bdring 于 2019-12-02

I can push my changes to the PR if you like.


#6 – odaki 于 2019-12-02

> I can push my changes to the PR if you like.

The M30 function is also very useful for me!
Please push the change.


#7 – odaki 于 2019-12-02

> Oh … My machine may be different from your original.
I commented out again and set $ 3 to 1 (original 2). This worked as intended.

I checked the wiring of the motor. I found that the Y motor connection was reversed. After correcting the wiring, it now works properly (commented out the X reverse code).


#8 – bdring 于 2019-12-02

It is easier to push the changes to devt. I’ll do that and close this PR.

Moved the cpumap to polarcoaster.h. I have been doing that when a machine has its own files.

Thanks for all your help!


原始Issue: https://github.com/bdring/Grbl_Esp32/pull/299

喜欢 (0)