[Grbl_Esp32 PR#137] Some considerations needed for compiling on macOS About GRBL HAL

Issue #137 | 状态: 已关闭 | 作者: odaki | 创建时间: 2019-05-03

A few fixes were needed to customize the firmware with macOS. Please merge into master if you can.
1. I changed the file name for EEPROM utility to avoid the name conflict with the standard header.
2. In order to use the correct library, I explicitly specified the dependent standard library in the platformio.ini file.

#1 – bdring 于 2019-05-03

Thank you, The changes look acceptable, but I would like a small modification.

Could you please rename the the “eeprom” files to grbleeprom rather than eeprommemcpy?

When original grbl filenames have a problem, I have been prefixing them with grbl_. This was the case with the limits file. This will keep it consistent and easier to compare back to original grbl.

Thank you

Bart

#2 – odaki 于 2019-05-04

Thank you for your comment.

I agree with you. I want to respect your rules.
(If I knew that there were rules for changing names, I would have done the same.)

Thank you.

原始Issue: https://github.com/bdring/Grbl_Esp32/pull/137

评论 (2)