[Grbl_Esp32 Issue#224] Display of gcode comments per NIST About GRBL HAL

Issue #224 | 状态: 已关闭 | 作者: bdring | 创建时间: 2019-09-15

标签: enhancement

Please describe the feature you would like implemented

The NIST gcode protocol V3 para. 3.3.4 says that comments on gcode that include “MSG” should be displayed by the machine. This could be useful for manual tool changes like…

M6 T7 (MSG,6mm Drill)

..reference

3.3.4 Comments and Messages
Printable characters and white space inside parentheses is a comment. A left parenthesis always
starts a comment. The comment ends at the first right parenthesis found thereafter. Once a left
parenthesis is placed on a line, a matching right parenthesis must appear before the end of the line.
Comments may not be nested; it is an error if a left parenthesis is found after the start of a
comment and before the end of the comment. Here is an example of a line containing a comment:

“G80 M5 (stop motion)”. Comments do not cause a machining center to do anything.

A comment contains a message if “MSG,” appears after the left parenthesis and before any other
printing characters. Variants of “MSG,” which include white space and lower case characters are
allowed. The rest of the characters before the right parenthesis are considered to be a message.
Messages should be displayed on the message display device. Comments not containing messages need not be displayed there.

Why do you think this would improve Grbl_ESP32?

Yes

Will this feature appear to a lot of users?

A few

#1 – bdring 于 2019-09-15

I think I have it working now.

M6 T7 (MSG,6mm Drill)

Displays as …

[MSG: GCode Comment 6mm Drill]

The message is sent to all communications channels…

“#define CLIENT_NONE 0 // (name changing soon) #define CLIENT_SERIAL 1 #define CLIENT_BT 2 #define CLIENT_WEBUI 3 #define CLIENT_TELNET 4“

I think it needs to be a [MSG: xxxxx] style so it does not break existing senders that are used to these types of messages.