[Grbl_Esp32 Issue#15] Leaving door pin floating causes crash loop

未分类 bolang 4个月前 (10-14) 40次浏览

Issue #15 | 状态: 已关闭 | 作者: unixbigot | 创建时间: 2018-08-04


When I first compiled and deployed to a breadboard, I received a crash loop.

After fitting pullups to button pins things settled down.

I’ll update the README.


评论 (7)

#1 – unixbigot 于 2018-08-04

Possibly due to bugs in early revs of the ESP32 silicon.


#2 – bdring 于 2018-08-04

I think all ESP32 silicone is that way. Here is a snippet from the datasheet.

!image


#3 – bdring 于 2018-08-04

It might be a good idea to add an optional way to turn off the use of control pins. Many (most?) people don’t use them and this would be a fast way to fix this issue in firmware.

@unixbigot What do you think about this? Maybe a #define USECONTROLPINS in cpu_map.h.


#4 – unixbigot 于 2018-08-13

I think an option to disable the front panel inputs is sensible. I’ve built several grbl machines without ever using the front panel inputs (though I’m adding them on one of my machines soon).


#5 – unixbigot 于 2018-08-13

I’ll send a PR


#6 – bdring 于 2018-08-21

@unixbigot

I took another look at this and decided to make this an option.

if #define IGNORECONTROLPINS is not commented out (the default) the switches will be ignored.


uint8t systemcontrolgetstate()
{
#ifdef IGNORECONTROLPINS
return 0;
#endif
...

I’ll include this in a future push.


#7 – bdring 于 2018-08-24

Closing latest push adds plenty of options for door and control pins.


原始Issue: https://github.com/bdring/Grbl_Esp32/issues/15

喜欢 (0)